Implement ICustomQueryInterface to support aggregation and hidden interfaces #128
Conversation
…support WinUI's assumptions around COM Aggregation and interface exclusivity.
…oritzinsky/custom-qi
…oritzinsky/custom-qi
…code-gen for overriding interfaces in sealed types.
jkoritzinsky
changed the title
|
We have an updated version of .NET now, so I've tested this against it and it seems to work. @stevenbrix can you run this against your test to make sure it's working as you expect? |
|
@jkoritzinksy, there is the |
|
Yep. I got a window entry to show up in the task bar but no visible window. I also was testing with the unpackaged app since the package wouldn't deploy. I don't know what behavior we were expecting once this was fixed, so I don't know if I got the expected behavior. |
|
Ok I investigated more and realized we weren't handling the overrides interfaces correctly (we were returning the native implementation instead of the managed implementation). Once that's handled, I'm still hitting an InvalidCastException in |
|
Yeah, the |
|
I think that needs to be fixed as part of this PR as well |
…overflow). Hold the "composed" object via an objectref and dispose it.
…than WinRT.Runtime and corelib.
…/cswinrt into jkoritzinsky/custom-qi
…that don't directly inherit from the overridable interface.
…/cswinrt into jkoritzinsky/custom-qi
|
Ok I've finally fixed all of the issues I could find with composition and overriding. We can now create a window on screen with a button, and when that button is clicked change the content to be a XAML-based user defined page. |
|
I found an RCW caching issue in this PR and fixed it as well as #143 since that was part of the cause. |
Implement ICustomQueryInterface and limited interface inheritance to support WinUI's assumptions around COM Aggregation and interface exclusivity.
Fixes #126